Opened 7 years ago

Closed 6 years ago

#228 closed defect (invalid)

Normalise variable names on types presented to the user

Reported by: erikd Owned by:
Priority: normal Milestone: 0.3.0
Component: Source Type Inferencer Version: 0.1.2
Keywords: Cc:

Description

Currently, trivial changes the the library code can result in changes in the names of region variables. For example, a library change may result in a test failure in test/15-Typing/Signatures/Bad/SmallerEffect2 of:

18,20c18,20
<  ,  $c2 =  ${xDE581 : %r0} + ${xDE581 : %r1} + ${xDE582 : %r2} + ${xDE583 : %r3}
<  ,  $c1 =  ${xDE581 : %r0} + ${xDE581 : %r1} + ${xDE582 : %r2}
<  ,  $c0 =  ${xDE581 : %r0} + ${xDE581 : %r1}
---
>  ,  $c2 =  ${xDE583 : %r0} + ${xDE583 : %r1} + ${xDE584 : %r2} + ${xDE585 : %r3}
>  ,  $c1 =  ${xDE583 : %r0} + ${xDE583 : %r1} + ${xDE584 : %r2}
>  ,  $c0 =  ${xDE583 : %r0} + ${xDE583 : %r1}

In this case, all thats changed is the auto-generated region variable names, eg xDE581 to xDE583 and xDE582 to xDE584.

It should be reasonable easy to hack something together that erases the variable names leaving just something like:

   ,  $c2 =  ${xDEXXX : %r0} + ${xDEXXX : %r1} + ${xDEXXX : %r2} + ${xDEXXX : %r3}
   ,  $c1 =  ${xDEXXX : %r0} + ${xDEXXX : %r1} + ${xDEXXX : %r2}
   ,  $c0 =  ${xDEXXX : %r0} + ${xDEXXX : %r1}

Change History (6)

comment:1 Changed 7 years ago by erikd

  • Component changed from Build System to Test runner (war)

comment:2 Changed 7 years ago by erikd

  • Summary changed from War : Make test runner recognise unimportant changes in type signatures to War : Make test runner ignore unimportant changes in type signatures

comment:3 Changed 7 years ago by benl

  • Milestone 0.1.3 deleted

Milestone 0.1.3 deleted

comment:4 Changed 7 years ago by benl

  • Component changed from Test runner (war) to Source Type Inferencer

The type inferencer should make nice names for these signatures so they don't have random numbers of the variables in the first place.

comment:5 Changed 7 years ago by benl

  • Summary changed from War : Make test runner ignore unimportant changes in type signatures to Normalise variable names on types presented to the user

comment:6 Changed 6 years ago by benl

  • Milestone set to 0.3.0
  • Resolution set to invalid
  • Status changed from new to closed

pony removal

Note: See TracTickets for help on using tickets.