Opened 5 years ago

Closed 5 years ago

#337 closed defect (fixed)

LLVM and C backends don't support NameExt

Reported by: amosrobinson Owned by:
Priority: normal Milestone: 0.4.2
Component: Unknown Version: 0.4.1
Keywords: Cc:

Description

This is a little annoying to test, as the name parser doesn't generate NameExts?. You'll just have to trust me.

I think all the pattern matches on NameVar? in packages/ddc-core-llvm/DDC/Core/Llvm/Convert/* could be replaced with something like

        C.XVar _ u@(C.UName (A.NameVar n))
         |  Just t      <- Env.lookup u tenv
         -> let n'      = A.sanitizeName n
                t'      = convertType pp kenv t

===>

        C.XVar _ u@(C.UName name)
         |  Just t      <- Env.lookup u tenv
         ,  n            <- show (ppr name)
         -> let n'      = A.sanitizeName n
                t'      = convertType pp kenv t

but there might be a nicer way.

Change History (1)

comment:1 Changed 5 years ago by amosrobinson

  • Resolution set to fixed
  • Status changed from new to closed

fixed for most cases in LLVM backend. there might be a few scragglers left in packages/ddc-core-salt/DDC/Core/Salt/Convert/* though

https://github.com/DDCSF/ddc/commit/81dfc75b193ecbd35d4d06c00f9b1617b5804847

Note: See TracTickets for help on using tickets.